bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

double-colon logic for normal rules


From: Boris Kolpackov
Subject: double-colon logic for normal rules
Date: Tue, 10 Feb 2004 17:35:20 -0600
User-agent: Mutt/1.5.4i

Good day,

In remake.c (cvs version) in function update_file there is a 
fragment of code which presumably is intended for double-colon
rules only (line 324-332):

  /* Process the remaining rules in the double colon chain so they're marked
     considered.  Start their prerequisites, too.  */
  for (; f != 0 ; f = f->prev)
    {
      struct dep *d;

      f->considered = considered;

      for (d = f->deps; d != 0; d = d->next)
        status |= update_file (d->file, depth + 1);
    }

However it is being run for normal rules as well. So I was wondering if
it should be changed to  

  if (file->double_colon)
    for (; f != 0 ; f = f->prev)
      {
       ...
  
at least for efficiency?


thanks,
-boris

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]