Build warnings in CVS make 3.81.90

[Jon Grant]

Hello,

I noticed a few build warnings in CVS at present. Difficult to spot a 
lot of the causes as there are many pre-processor macros in use.

A wider query relating to these warnings is that since make 3.81 is 
released now, could we change make to use const's instead of #define'd 
values, and inline functions instead of #define macro expressions? Would 
a patch be accepted to change over such pre-processor expressions into 
native code?

Regards, Jon


file.c: In function 'file_timestamp_cons':
file.c:765: warning: comparison of unsigned expression < 0 is always false
file.c:766: warning: comparison between signed and unsigned
file.c:766: warning: comparison of unsigned expression < 0 is always false
file.c:769: warning: comparison of unsigned expression < 0 is always false

^^ Looks like the last arg, "int ns" doesn't need to be signed.

function.c: In function 'func_lastword':
function.c:696: warning: 'p' may be used uninitialized in this function
function.c: In function 'func_shell':
function.c:1597: warning: variable 'error_prefix' might be clobbered by 
'longjmp' or 'vfork'
function.c:1589: warning: argument 'o' might be clobbered by 'longjmp' 
or 'vfork'


main.c: In function 'main':
main.c:1825: warning: comparison of unsigned expression < 0 is always false
main.c:2152: warning: comparison of unsigned expression < 0 is always false

remake.c: In function 'update_file_1':
remake.c:436: warning: comparison of unsigned expression < 0 is always false
remake.c: In function 'notice_finished_file':
remake.c:869: warning: comparison of unsigned expression < 0 is always false
remake.c: In function 'f_mtime':
remake.c:1240: warning: comparison of unsigned expression < 0 is always 
false
remake.c:1253: warning: comparison of unsigned expression < 0 is always fa