[bug #24655] shell_var.length isn't set causing duplicates from target_environment.

[Knut St. Osmundsen]

URL:
  <http://savannah.gnu.org/bugs/?24655>

                 Summary: shell_var.length isn't set causing duplicates from
target_environment.
                 Project: make
            Submitted by: bird_tori
            Submitted on: Sun 26 Oct 2008 11:02:30 PM CET
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
       Component Version: 3.81
        Operating System: Any
           Fixed Release: None

    _______________________________________________________

Details:

target_environment() uses a temporary hash table for collecting exported
variables from the sets.   This table uses variable_hash_1 and variable_hash_2
which expect the struct variable::length field to be correct and will generate
incorrect values for the shell_var since its length field is 0.

The result is, for instance, that the last test in
tests/scripts/variables/SHELL exports the wrong SHELL variable.

The fix is very simple, just initialize shell_var.length to 5 in main.c (line
1189 in r1.227). 




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?24655>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/