bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [rfc] Colorized output for GNU make?


From: Sebastian Pipping
Subject: Re: [rfc] Colorized output for GNU make?
Date: Tue, 11 Oct 2011 22:11:23 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110928 Thunderbird/6.0.2

Hello!


On 10/11/2011 07:51 PM, Paul Smith wrote:
> I have no problem with the concept of colorized output, as long as it
> meets the following requirements:
> 
>       * The default is "no color" mode as now

Agreed.


>       * The implementation is clean and portable and doesn't add lots of
>         complexity to the code.  Does everything support the color codes
>         you're using?  I don't want to have to link with ncurses or
>         something to get portable colorization.

No plans on using ncurses here.  I suppose if we do what grep does were
safe enough portability-wise?  I'll check what I can learn from there.

Regarding complexity it may (or may not) be necessary to split newlines
off some translations strings and concat them at runtime, instead.  It
depends on the question if "\n" itself should be colorized or not.
In general I don't expect much complexity.


>       * The color designation is flexible: the last thing I want to do
>         is get into a situation where we are scrambling to find
>         acceptable colors for those who prefer terminals with light
>         backgrounds, dark backgrounds, color blind folks, etc.

Customizable, yes.


>         I also
>         don't want to have a new ~/.makerc file or something just to
>         define color schemes.

Okay.  I guess that leaves command line options, environment variables
or both.  Any preferences?


>       * Based on the above it seems like the code required to implement
>         this will be sufficiently large that it will require copyright
>         assignment to the FSF.

Alright.  Please initiate the copyright assignment process.


>       * Patches based on the current CVS latest version of GNU make are
>         easier for me to examine/apply/test.

Sure.

I will follow GNU make CVS in this new Git repo of mine [1].

I have ported patch v1 presented earlier to the current state in CVS.
It's in branch "color-v1.1" of [1], this URL [2] serves a raw patch.


I noticed that there is no bootstrap/autogen.sh script in CVS.
What do I need to run to bootstrap GNU make?
It seems that

  # autoreconf -i && ./configure && make

leaves me with a repeated warning

  [..]
  configure.in:128: warning: AC_LANG_CONFTEST:
     no AC_LANG_SOURCE call detected in body
  [..]

from autoreconf and a "File be.po does not exist" error from make:

  [..]
  make[4]: Entering directory `/home/sping/__playground/make/po'
  File be.po does not exist. If you are a translator, you can create it
    through 'msginit'.
  make[4]: *** [be.po-create] Error 1
  [..]

Could you add a bootstrap/autogen.sh script to CVS?

Best,



Sebastian


[1] http://git.goodpoint.de/?p=make.git;a=summary
[2]
http://git.goodpoint.de/?p=make.git;a=patch;h=c901be5018830bbc5d9b2cac553fd4174189659b



reply via email to

[Prev in Thread] Current Thread [Next in Thread]