Re: [PATCH] Fix issue with PowerPC, char is unsigned by default

[Anton Blanchard]

Hi,

Just checking on this patch. Without it make on PowerPC is broken.

Anton
--

On Mon, 17 Jun 2013 13:59:05 +1000
Anton Blanchard <address@hidden> wrote:

commit 8b034b7d (Small cleanups and fixes) changed update_status
from a short int to a char. On PowerPC a char is unsigned by default
and this means things that set update_status to -1 do not work any
more.

2013-05-07  Anton Blanchard  <address@hidden>

        * filedef.h (update_status): Make signed

Index: b/filedef.h
===================================================================
--- a/filedef.h
+++ b/filedef.h
@@ -59,7 +59,7 @@ struct file
     FILE_TIMESTAMP mtime_before_update; /* File's modtime before any updating
                                            has been performed.  */
     int command_flags;          /* Flags OR'd in for cmds; see commands.h.  */
-    char update_status;         /* Status of the last attempt to update,
+    signed char update_status;  /* Status of the last attempt to update,
                                    or -1 if none has been made.  */
     enum cmd_state              /* State of the commands.  */
       {         /* Note: It is important that cs_not_started be zero.  */