[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated |
Date: |
Mon, 05 Aug 2013 21:20:00 +0300 |
> Date: Mon, 5 Aug 2013 21:34:31 +0400
> From: Pavel Fedin <address@hidden>
>
> fork()-based code temporary sets 'environ' variable to child's environment,
> which appears to contain current directory. EMX code didn't do that.
> The problem gets triggered only if you try to call something which is not in
> your system PATH. Cygwin's spawnvpe() screws up badly in such situation.
> The new patch is attached. I have tested building Cygwin source, works fine.
> Please test. If OK, i can retry pushing it upstream.
Once again, please make this a run-time option, off by default,
activated by a command-line argument. Not a compile-time feature.
Using spawn by default for Cygwin is a non-starter.
Also, you are now modifying the EMX parts of the code, and I at least
have no way of knowing whether those changes will work well for EMX.
So please guard them with a Cygwin-specific conditional.
Thanks.
- [PATCH] Use spawn() in GNU Make on Cygwin, updated, Pavel Fedin, 2013/08/05
- Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated,
Eli Zaretskii <=
- RE: [PATCH] Use spawn() in GNU Make on Cygwin, updated, Pavel Fedin, 2013/08/06
- Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated, Eli Zaretskii, 2013/08/06
- RE: [PATCH] Use spawn() in GNU Make on Cygwin, updated, Pavel Fedin, 2013/08/07
- Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated, Denis Excoffier, 2013/08/11
- Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated, Pavel Fedin, 2013/08/11
- Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated, Christopher Faylor, 2013/08/16
- Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated, Pavel Fedin, 2013/08/16
- Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated, Paul Smith, 2013/08/16
- Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated, Christopher Faylor, 2013/08/16
- Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated, Paul Smith, 2013/08/16