bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] Fix abspath on Cygwin/MSYS with DOS paths enabled


From: Pavel Fedin
Subject: [PATCH 1/2] Fix abspath on Cygwin/MSYS with DOS paths enabled
Date: Fri, 09 Aug 2013 17:28:34 +0400

 Hello! This is the new patch. Allows to enable DOS paths on Cygwin with no
abspath breaking.
 The idea of the change: instead of single HAVE_DOS_PATHS definition we now
have two definitions:

1. HAVE_DOS_PATHS - says that the platform is capable of handling DOS paths
in principle.
2. NATIVE_DOS_PATHS - says that DOS paths are native for this platform, and
functions like getcwd() return DOS-style paths.

 NATIVE_DOS_PATHS now determines two things:

1. Expansion of relative paths (root_len value).
2. Fallback value of PATH_SEPARATOR_CHAR, unless provided by configure.

 I have tested the change on Cygwin and Windows. Works fine, no problems
were discovered. Unfortunately test suite reports lots of errors for Windows
version because it's designed to work only on POSIX, but visual inspection
of results reveals that abspath works correctly in both cases.
 Now it should be OK to keep HAVE_DOS_PATHS enabled on Cygwin, with this
change configure hint can be removed.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia

Attachment: make-3.82.90-1-fix-dos-paths-compatibility.diff
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]