Re: GNU make 4.0.90 prerelease available

[Eli Zaretskii]

> From: Denis Excoffier <address@hidden>
> Date: Thu, 2 Oct 2014 12:23:04 +0200
> Cc: Eli Zaretskii <address@hidden>
> 
> 
> On 2014-10-01 20:03, Eli Zaretskii wrote:
> 
> >> From: Denis Excoffier <address@hidden>
> >> Date: Wed, 1 Oct 2014 19:55:13 +0200
> >> 
> >> For me, under Cygwin, i had to apply the following in order to compile 
> >> (GCC 4.9.1):
> >> 
> >> diff -uNrp make-4.0.90-original/job.c make-4.0.90-patched/job.c
> >> --- make-4.0.90-original/job.c     2014-09-30 14:18:39.000000000 +0200
> >> +++ make-4.0.90-patched/job.c      2014-10-01 19:42:12.000000000 +0200
> >> @@ -2694,7 +2694,7 @@ construct_command_argv_internal (char *l
> >>   /* This is required if the MSYS/Cygwin ports (which do not define
> >>      WINDOWS32) are compiled with HAVE_DOS_PATHS defined, which uses
> >>      sh_chars_sh directly (see below).  */
> >> -  static const char *sh_chars_sh = sh_chars;
> >> +  const char *sh_chars_sh = sh_chars;
> >> # endif  /* HAVE_DOS_PATHS */
> >> #endif
> >>   int i;
> > 
> > What happens if you don't?
> > 
> Otherwise i get the following:
> 
> job.c: In function 'construct_command_argv_internal':
> job.c:2697:3: error: initializer element is not constant
>   static const char *sh_chars_sh = sh_chars;
>   ^
> make[2]: *** [job.o] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
> 
> This occurs with GCC 4.9.1 and also with the regular /usr/bin/gcc on cygwin 
> (GCC 4.8.3).

Thanks, I fixed this in a slightly different way.