bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Some DJGPP specific fixes for Make 4.2.1 and later.


From: Eli Zaretskii
Subject: Re: Some DJGPP specific fixes for Make 4.2.1 and later.
Date: Sun, 12 Jun 2016 20:28:20 +0300

> Date: Sun, 12 Jun 2016 19:18:36 +0200
> From: "Juan Manuel Guerrero (address@hidden) [via address@hidden" 
> <address@hidden>
> 
>     -  For systems like MSDOS, WINDOWS32 and other ones, the function 
> get_bad_stdin
>        is defined as a no-op macro in os.h but at the same time exists an
>        implementation of the function in posixos.c.  This implementation
>        is always compiled no matter if __MSDOS__ and/or MAKE_JOBSERVER is
>        defined or not in posixos.c.  To avoid this contradiction, I have put
>        the get_bad_stdin definition inside the same #ifdef than the ones used
>        in os.h.  Please inspect the patch.  This approach is only a 
> suggestion;
>        may be there is a different way to solve this issue.

posixos.c is not supposed to be compiled on MSDOS (or any other
non-Posix system).  Why is it being compiled in the DJGPP build?

The other changes look fine to me, thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]