bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

output-sync test failure


From: Earnestly
Subject: output-sync test failure
Date: Thu, 2 Nov 2017 11:44:45 +0000
User-agent: Mutt/1.9.1 (2017-09-22)

Hi,

Commit 0c5a9f9b92af1634dc60fa21e9ac86ed50e5d595 has caused the
output-sync test to fail with the following diff:

    *** work/features/output-sync.base.2        Thu Nov  2 11:19:14 2017
    --- work/features/output-sync.log.2 Thu Nov  2 11:18:45 2017
    ***************
    *** 2,8 ****
      sleep 1 ; /home/earnest/build/pkgbuilds/make-git/src/make/tests/../make 
-C bar
      bar: start
      bar: end
    - foo: start
    - foo: end
    - baz: start
    - baz: end
    --- 2,4 ----

Reverting the following change allows the test to pass:

    * tests/scripts/features/output-sync: Remove useless rm command.

    diff --git a/tests/scripts/features/output-sync 
b/tests/scripts/features/output-sync
    index 1407e81..0ecc919 100644
    --- a/tests/scripts/features/output-sync
    +++ b/tests/scripts/features/output-sync
    @@ -45,7 +45,7 @@ sub output_sync_clean {
     # reliable.  If things are too fast, then sometimes a different job will 
steal
     # the output sync lock and the output is mis-ordered from what we expect.
     sub output_sync_wait {
    -    return "while [ ! -f ../mksync.$_[0] ]; do :; done; $CMD_rmfile 
../mksync.$_[0].wait; $sleep_command 1";
    +    return "while [ ! -f ../mksync.$_[0] ]; do :; done; $sleep_command 1";
     }
     sub output_sync_set {
         return "date > ../mksync.$_[0]"

Is this a genuine test failure or was this unintended?

Thanks



reply via email to

[Prev in Thread] Current Thread [Next in Thread]