bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #65588] A buffer overrun in handling of .SHELLFLAGS.


From: Andrei Horodniceanu
Subject: [bug #65588] A buffer overrun in handling of .SHELLFLAGS.
Date: Fri, 26 Apr 2024 16:50:50 -0400 (EDT)

Follow-up Comment #3, bug #65588 (group make):

Your first patch (sv65588_part1.diff) doesn't apply currently. The rejected
snippet is:

--- src/job.c
+++ src/job.c
@@ -2839,7 +2841,8 @@ construct_command_argv_internal (char *line, char
**restp, const char *shell,
     return 0;
 
   if (shellflags == 0)
-    shellflags = posix_pedantic && NONE_SET (flags, COMMANDS_NOERROR) ? "-ec"
: "-c";
+    shellflags = defsh_flags;
+  assert (shellflags);
 
   /* See if it is safe to parse commands internally.  */
   if (shell == 0)


The rest of the patches apply fine and fix the issue for me.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65588>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]