Re: texi2dvi: set -e, use tar

[Karl Berry]

Hi Akim,

            * util/texi2dvi: set -e.

I have had nothing but problems with -e.  Whenever I have used it, I
always end up taking it again, because a nonzero exit status simply does
not always mean failure.  Are you really sure we need this?
What do we gain?

            Stop using the idiom "test && action" in favor of "if test; then
            action; fi".

Hmm, I'm not crazy about this either.  I assume it was because of the set -e
-- another problem with it; && seems like a perfectly reasonable shell
construct, why prevent ourselves from being able to use it?

Also, one source line becoming three doesn't seem good to me.  The
script is already too long ...

            (xref_files_save): Use tar instead of cp.

Because ... ?  Although I don't suppose it matters in practice.  cp just
seems simpler.

Thanks,
karl