bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] small memory leak in makeinfo.c:convert_from_file


From: Karl Berry
Subject: Re: [patch] small memory leak in makeinfo.c:convert_from_file
Date: Fri, 21 Sep 2007 18:02:22 -0500

Hi Stephen,

    It also removes some code that does nothing as long as `suffixes' stays
    more or less like it is.

Ok, agreed & removed.

    Subject: [patch] small memory leak in makeinfo.c:convert_from_file

I agree there's a memory leak, but I worry about this free.
input_filename is set in many places to many things, including
references in structures, etc.  It seems like the free could invalidate
them.  Am I missing something?  I didn't actually try to find a test
case, just eyeballed the sources ...

The truth is, I have not tried very hard to eliminate such small memory
leaks.  In fact, I've added plenty.  Life is just too short ... makes no
real difference in a short-lived process like makeinfo that I can see.

Thanks,
Karl




reply via email to

[Prev in Thread] Current Thread [Next in Thread]