Re: Current trunk is broken for MinGW, patches included

[Eli Zaretskii]

> Date: Thu, 25 Dec 2014 17:33:59 +0000
> From: Gavin Smith <address@hidden>
> Cc: Texinfo <address@hidden>
> 
> On Wed, Dec 24, 2014 at 5:41 PM, Eli Zaretskii <address@hidden> wrote:
> > In addition, there are non-fatal warnings: libiconv routines are
> > called with 'char **' arguments where the functions expect to get a
> > 'const char **' argument, and there's one case of conflicting
> > prototypes in pcterm.c.  Patch for the latter is below; as for the
> > iconv problem, I'm unsure how best to solve this, since I don't
> > understand why the code doesn't use the correct types -- perhaps
> > because non-GNU implementations of libiconv need that?
> 
> Which functions are giving warnings?

I reproduce the warnings below.

> All the documentation I have looked at for "iconv" doesn't show
> "const" for any of the arguments.

I have in my include/iconv.h:

  #ifndef LIBICONV_PLUG
  #define iconv libiconv
  #endif
  extern size_t iconv (iconv_t cd, const char* * inbuf, size_t *inbytesleft, 
char* * outbuf, size_t *outbytesleft);

Here are the warnings I get:

     info-utils.c: In function 'copy_converting':
     info-utils.c:915:30: warning: passing argument 2 of 'libiconv' from 
incompatible pointer type [enabled by default]
     In file included from info-utils.h:30:0,
                      from info-utils.c:24:
     d:\usr\bin\../lib/gcc/mingw32/4.7.2/../../../../include/iconv.h:83:15: 
note: expected 'const char **' but argument is of type 'char **'

     info-utils.c: In function 'text_buffer_iconv':
     info-utils.c:1969:22: warning: passing argument 2 of 'libiconv' from 
incompatible pointer type [enabled by default]
     In file included from info-utils.h:30:0,
                      from info-utils.c:24:
     d:\usr\bin\../lib/gcc/mingw32/4.7.2/../../../../include/iconv.h:83:15: 
note: expected 'const char **' but argument is of type 'char **'