Re: texinfo-5.9.90 pretest available

[Ken Brown]

On 2/26/2015 12:13 PM, Gavin Smith wrote:
> On 25 February 2015 at 23:21, Ken Brown <address@hidden> wrote:
>> The remaining test failures are in install-info/tests, and are ii-0041,
>> ii-0050, and ii-0054.  These are the ones that involve a gzipped dir file.
>> In all three cases the failure was
>>
>>    gzip: stdin: unexpected end of file
>>
> 
> The contents of "tests/ii-0041-test.log" could be useful.
> 
> I'd expect this is an error message from gzip when it is being run to
> read in the dir file into install-info

Yes, it's an error message from gzip.  I stepped through ginstall-info in gdb 
and found that the error message comes right after the popen call in line 847 
of install-info.c.

Maybe I'm missing something, but how could that popen call possibly DTRT?  
"gzip -d" has been called without being given the name of the file to 
decompress.  Don't we need something like the following?

Index: install-info/install-info.c
===================================================================
--- install-info/install-info.c (revision 6157)
+++ install-info/install-info.c (working copy)
@@ -843,7 +843,7 @@
 
   if (*compression_program)
     { /* It's compressed, so open a pipe.  */
-      char *command = concat (*compression_program, " -d", "");
+      char *command = concat (*compression_program, " -d ", *opened_filename);
       f = popen (command, "r");
       if (! f)
         {

Ken