bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Using iconv in stand-alone info


From: Eli Zaretskii
Subject: Re: Using iconv in stand-alone info
Date: Sat, 26 Dec 2015 09:34:05 +0200

> Date: Fri, 25 Dec 2015 21:59:45 +0000
> From: Gavin Smith <address@hidden>
> Cc: Texinfo <address@hidden>
> 
> On 25 December 2015 at 21:52, Gavin Smith <address@hidden> wrote:
> >
> > That may not come out right but the point is that "\201" isn't at the
> > end, when it should be.
> >
> > I think this will be easy to fix, I'll probably do it today or tomorrow.
> 
> Here's the fix; I'll commit tomorrow unless a problem comes to light.
> 
> Index: info-utils.c
> ===================================================================
> --- info-utils.c        (revision 6893)
> +++ info-utils.c        (working copy)
> @@ -901,6 +901,10 @@ copy_converting (long n)
>          }
> 
>        /* Degrade to ASCII. */
> +
> +      /* Flush any waiting input in iconv_to_output and enter the
> +         default shift state. */
> +      text_buffer_iconv (&output_buf, iconv_to_output, NULL, NULL);
> 
>        if (file_is_in_utf8)
>          {
> 

Perhaps it would be better to put this in the EILSEQ part of the
switch above.  The result should be the same, AFAICT, since EILSEQ is
the only case when we don't 'continue' or 'return', but having the
code there makes it more self-explanatory (although some comment might
still be in order).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]