Re: texinfo-6.0.91 pretest

[Eli Zaretskii]

> Date: Fri, 1 Jan 2016 21:23:28 +0000
> From: Gavin Smith <address@hidden>
> Cc: Texinfo <address@hidden>
> 
> On 1 January 2016 at 21:19, Eli Zaretskii <address@hidden> wrote:
> >> No Perl header files are included in text.c.
> >
> > Why can't we include Perl headers there?
> 
> No reason. If the latest change I committed doesn't work, it's worth trying.
> 
> > No, it's coming from XS_Texinfo__Convert__XSParagraph__XSParagraph_add_text.
> 
> OK that makes sense.

I applied the latest changes from the repository, and the crashes are
gone!

A few observations and issues with the rest of the build:

"make install" installs the XSParagraph shared libraries into
${prefix}/libexec/texinfo -- is that the correct place?  Will Perl
find these modules when texi2any runs it?

Also, "make install" seems to install the TestXS shared library as
well -- is that intended?

The test suite passes as well -- with a single exception of htmlxref
tests, see below.  But I think I saw some message from you that
XSParagraph modules are disabled during the tests?  (How does one
disable that once Texinfo is installed, btw?  I might need that
if/when I see any abnormal results from running makeinfo.)

The failures in htmlxref tests are due to a formatting issue.  The
diffs look like this:

     diff --strip-trailing-cr -a -u -r 
.//diffs/staging_res/htmlxref_nodes/test_refs.2 
.//out_parser/htmlxref_nodes/test_refs.2
     --- .//diffs/staging_res/htmlxref_nodes/test_refs.2     2014-12-19 
22:07:28 +0200
     +++ .//out_parser/htmlxref_nodes/test_refs.2    2016-01-02 11:36:15 +0200
     @@ -1,2 +1,2 @@
     -./htmlxref.cnf:15: warning: unrecognized type: foo
     -./htmlxref.cnf:16: warning: missing type
     +htmlxref.cnf:15: warning: unrecognized type: foo
     +htmlxref.cnf:16: warning: missing type
     FAIL test_scripts/htmlxref_htmlxref_nodes.sh (exit status: 1)

So it's a "./foo" vs "foo" issue.  I don't think this is a real
problem, is it?  If so, can this be fixed somehow so as not to cause
bogus failure indications?  (Btw, why two slashes in "//diffs"?)

Thanks.