bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Texinfo 6.1 released


From: Gavin Smith
Subject: Re: Texinfo 6.1 released
Date: Sat, 6 Feb 2016 19:32:03 +0000

On 6 February 2016 at 19:14, Eli Zaretskii <address@hidden> wrote:
>> We have released Texinfo 6.1, the GNU documentation format.
> Thanks.
>
> I had the compilation warnings shown at the end of this message when
> building this with MinGW on MS-Windows.
>
> I ignored the realloc warnings: they seem to be due to fighting
> between Gnulib redefinitions and Perl headers redefinitions, and I see
> no way of avoiding them.  They also seem harmless.

Seems harmless to me as well.

>
> The popen/pclose issue seems more serious; I fixed it like this:
>
> --- tp/Texinfo/Convert/XSParagraph/xspara.c~0   2016-01-23 13:31:17.000000000 
> +0200
> +++ tp/Texinfo/Convert/XSParagraph/xspara.c     2016-02-06 20:30:33.083250000 
> +0200
> @@ -198,6 +198,16 @@ iswupper (wint_t wc)
>    return 1;
>  }
>
> +/* Avoid warnings due to redefinition of popen/pclose in Perl headers.  */
> +#ifdef popen
> +# undef popen
> +# define popen(c,m) _popen(c,m)
> +#endif
> +#ifdef pclose
> +# undef pclose
> +# define pclose(f)  _pclose(f)
> +#endif
> +
>  #endif

I see this code is in the #ifdef _WIN32 section, so I'm happy with it
even if I don't understand it.

One worry I have is why Perl is redefining popen/pclose in the first
place and if problems could occur on other systems, like Cygwin. (Ken
cc'd).

>
>  int
>
>
> If you agree, I will install this in the Texinfo repository.
>
> Here are the warnings (btw, why does the compilation command say
> "-DVERSION=\"6.0\""? shouldn't it be 6.1 instead?):
>
>      /bin/xsubpp -typemap D:/usr/Perl/lib/ExtUtils/typemap XSParagraph.xs > 
> XSParagraph.xsc && mv XSParagraph.xsc XSParagraph.c
>      /bin/sh ./libtool  --tag=CC   --mode=compile d:/usr/bin/gcc.exe 
> -DHAVE_CONFIG_H -I.  -I.                 -I./lib      -I./lib  -DWIN32 
> -DPERL_TEXTMODE_SCRIPTS -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT 
> -DPERL_IMPLICIT_SYS -DUSE_PERLIO    -DVERSION=\"6.0\"  -DXS_VERSION=\"1\"  
> "-ID:/usr/Perl/lib/CORE"  -MT XSParagraph_la-XSParagraph.lo -MD -MP -MF 
> .deps/XSParagraph_la-XSParagraph.Tpo -c -o XSParagraph_la-XSParagraph.lo 
> `test -f 'XSParagraph.c' || echo './'`XSParagraph.c
>      libtool: compile:  d:/usr/bin/gcc.exe -DHAVE_CONFIG_H -I. -I. -I./lib 
> -I./lib -DWIN32 -DPERL_TEXTMODE_SCRIPTS -DUSE_SITECUSTOMIZE 
> -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -DVERSION=\"6.0\" 
> -DXS_VERSION=\"1\" -ID:/usr/Perl/lib/CORE -MT XSParagraph_la-XSParagraph.lo 
> -MD -MP -MF .deps/XSParagraph_la-XSParagraph.Tpo -c XSParagraph.c  
> -DDLL_EXPORT -DPIC -o .libs/XSParagraph_la-XSParagraph.o
>      In file included from XSParagraph.xs:8:0:
>      D:/usr/Perl/lib/CORE/XSUB.h:564:0: warning: "realloc" redefined [enabled 
> by default]
>       #    define realloc  PerlMem_realloc
>       ^
>      In file included from D:/usr/Perl/lib/CORE/perl.h:766:0,
>                       from XSParagraph.xs:7:
>      ./lib/stdlib.h:1060:0: note: this is the location of the previous 
> definition
>       #   define realloc rpl_realloc
>       ^
>      libtool: compile:  d:/usr/bin/gcc.exe -DHAVE_CONFIG_H -I. -I. -I./lib 
> -I./lib -WIN32 -DPERL_TEXTMODE_SCRIPTS -DUSE_SITECUSTOMIZE 
> -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -DVERSION=\"6.0\" 
> -DXS_VERSION=\"1\" -ID:/usr/Perl/lib/CORE -MT XSParagraph_la-XSParagraph.lo 
> -MD -MP -MF .deps/XSParagraph_la-XSParagraph.Tpo -c XSParagraph.c -o 
> XSParagraph_la-XSParagraph.o >/dev/null 2>&1
>      mv -f .deps/XSParagraph_la-XSParagraph.Tpo 
> .deps/XSParagraph_la-XSParagraph.Plo
>      /bin/sh ./libtool  --tag=CC   --mode=compile d:/usr/bin/gcc.exe 
> -DHAVE_CONFIG_H -I.  -I.                 -I./lib      -I./lib  -DWIN32 
> -DPERL_TEXTMODE_SCRIPTS -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT 
> -DPERL_IMPLICIT_SYS -DUSE_PERLIO    -DVERSION=\"6.0\"  -DXS_VERSION=\"1\"  
> "-ID:/usr/Perl/lib/CORE"  -MT XSParagraph_la-xspara.lo -MD -MP -MF 
> .deps/XSParagraph_la-xspara.Tpo -c -o XSParagraph_la-xspara.lo `test -f 
> 'xspara.c' || echo './'`xspara.c
>      libtool: compile:  d:/usr/bin/gcc.exe -DHAVE_CONFIG_H -I. -I. -I./lib 
> -I./lib -DWIN32 -DPERL_TEXTMODE_SCRIPTS -DUSE_SITECUSTOMIZE 
> -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -DVERSION=\"6.0\" 
> -DXS_VERSION=\"1\" -ID:/usr/Perl/lib/CORE -MT XSParagraph_la-xspara.lo -MD 
> -MP -MF .deps/XSParagraph_la-xspara.Tpo -c xspara.c  -DDLL_EXPORT -DPIC -o 
> .libs/XSParagraph_la-xspara.o
>      In file included from xspara.c:35:0:
>      D:/usr/Perl/lib/CORE/XSUB.h:564:0: warning: "realloc" redefined [enabled 
> by default]
>       #    define realloc  PerlMem_realloc
>       ^
>      In file included from xspara.c:20:0:
>      ./lib/stdlib.h:1060:0: note: this is the location of the previous 
> definition
>       #   define realloc rpl_realloc
>       ^
>      xspara.c: In function 'xspara_init':
>      xspara.c:251:5: warning: assignment from incompatible pointer type 
> [enabled by default]
>         p = popen ("locale -a", "r");
>           ^
>      xspara.c:260:11: warning: passing argument 2 of 
> 'my_perl->IProc->pPclose' from incompatible pointer type [enabled by default]
>                 pclose (p);
>                 ^
>      xspara.c:260:11: note: expected 'struct PerlIOl **' but argument is of 
> type 'struct FILE *'
>      xspara.c:269:15: warning: passing argument 2 of 
> 'my_perl->IProc->pPclose' from incompatible pointer type [enabled by default]
>                     pclose (p);
>                     ^
>      xspara.c:269:15: note: expected 'struct PerlIOl **' but argument is of 
> type 'struct FILE *'



reply via email to

[Prev in Thread] Current Thread [Next in Thread]