[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 'info mount' doesn't follow ref
From: |
Vitezslav Crhonek |
Subject: |
Re: 'info mount' doesn't follow ref |
Date: |
Mon, 10 Jul 2017 10:26:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/09/2017 08:55 PM, Gavin Smith wrote:
> On Mon, Jul 03, 2017 at 03:17:33PM +0200, Vitezslav Crhonek wrote:
>> The culprit seems to be info_find_subfile() function in nodes.c,
>> more precisely this line:
>> /* Check if fullpath starts the name of the recorded file (extra
>> extensions like ".info.gz" could be added.) */
>> if (!strncmp (file_buffer->fullpath, fullpath, strlen (fullpath)))
>>
>> If "/usr/share/info/libc.info-11" is on the list of already
>> loaded files ('info mount' case), that comparison falsely succeeds
>> (!strncmp ("/usr/share/info/libc.info-11",
>> "/usr/share/info/libc.info-1",
>> 27))
>>
>> But the node obviously isn't present there and following the reference
>> fails in the end. Otherwise correct file
>> "/usr/share/info/libc.info-1.gz" is found and the node is displayed.
>
> I've committed a change that should fix this. It will be included in
> future releases.
>
Thank you, the fix looks fine and I can confirm that it works as
expected.
Vita
--
Vitezslav Crhonek
Software Engineer
Red Hat
signature.asc
Description: OpenPGP digital signature