Failure to build 6.8 with ~glibc-2.34

[Sam James]

Hi!

glibc-2.34 isn't released yet, but most/all breaking changes should be in their 
git already. I tested
using glibc at commit d34ed66f96fa9316654d7adb2afcce4be1d1c4f5.

Downstream in Gentoo [0], we've started testing packages in order to keep an 
eye out for problems.

I was unable to build texinfo 6.8 with the following errors:
```
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../..     -O2 -pipe -march=native 
-fdiagnostics-color=always -frecord-gcc-switches -c -o uniwidth/width.o 
uniwidth/width.c
In file included from regexec.c:1368,
                 from regex.c:74:
./malloc/dynarray-skeleton.c:195:24: error: expected declaration specifiers or 
‘...’ before ‘(’ token
  195 | __attribute_nonnull__ ((1))
      |                        ^
./malloc/dynarray-skeleton.c:205:51: error: expected declaration specifiers or 
‘...’ before ‘(’ token
  205 | __attribute_maybe_unused__ __attribute_nonnull__ ((1))
      |                                                   ^
./malloc/dynarray-skeleton.c:216:24: error: expected declaration specifiers or 
‘...’ before ‘(’ token
  216 | __attribute_nonnull__ ((1))
      |                        ^
./malloc/dynarray-skeleton.c:225:24: error: expected declaration specifiers or 
‘...’ before ‘(’ token
  225 | __attribute_nonnull__ ((1))
      |                        ^
./malloc/dynarray-skeleton.c:239:24: error: expected declaration specifiers or 
‘...’ before ‘(’ token
  239 | __attribute_nonnull__ ((1))
      |                        ^
./malloc/dynarray-skeleton.c:248:24: error: expected declaration specifiers or 
‘...’ before ‘(’ token
  248 | __attribute_nonnull__ ((1))
      |                        ^
./malloc/dynarray-skeleton.c:260:24: error: expected declaration specifiers or 
‘...’ before ‘(’ token
  260 | __attribute_nonnull__ ((1))
      |                        ^
./malloc/dynarray-skeleton.c:270:24: error: expected declaration specifiers or 
‘...’ before ‘(’ token
  270 | __attribute_nonnull__ ((1))
      |                        ^
./malloc/dynarray-skeleton.c: In function ‘regmatch_list_add__’:
regexec.c:1367:26: warning: implicit declaration of function 
-Wimplicit-function-declaration][]]
 1367 | #define DYNARRAY_PREFIX  regmatch_list_
      |                          ^~~~~~~~~~~~~~
./malloc/dynarray-skeleton.c:149:40: note: in definition of macro 
‘DYNARRAY_CONCAT0’
  149 | #define DYNARRAY_CONCAT0(prefix, name) prefix##name
      |                                        ^~~~~~
./malloc/dynarray-skeleton.c:151:29: note: in expansion of macro 
‘DYNARRAY_CONCAT1’
  151 | #define DYNARRAY_NAME(name) DYNARRAY_CONCAT1(DYNARRAY_PREFIX, name)
      |                             ^~~~~~~~~~~~~~~~
./malloc/dynarray-skeleton.c:151:46: note: in expansion of macro 
‘DYNARRAY_PREFIX’
  151 | #define DYNARRAY_NAME(name) DYNARRAY_CONCAT1(DYNARRAY_PREFIX, name)
      |                                              ^~~~~~~~~~~~~~~
./malloc/dynarray-skeleton.c:286:7: note: in expansion of macro ‘DYNARRAY_NAME’
  286 |       DYNARRAY_NAME (mark_failed) (list);
      |       ^~~~~~~~~~~~~
```

They appear to be fixed upstream in gnulib - there's a variety of commits [1]
which solve conflicting macros. Following README-hacking, I updated gnulib
to commit c567dcac24dd90a2be051772d9a8c8bbf869221a there and texinfo builds!

Please let me know if I can provide any other useful information!

[0] https://bugs.gentoo.org/803485
[1] 
https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=0c907f7da13232908f05c415b8cec56024071906

signature.asc
Description: Message signed with OpenPGP