Re: texi2any aborts with empty @image argument

[Patrice Dumas]

On Tue, Nov 08, 2022 at 04:58:39PM +0000, Gavin Smith wrote:
> I suspect this is related to the following change:

Exactly.  And other similar crashes may happen.  I tried to check the
code as much as possible to avoid them, but I have probably missed some.

> 2022-09-17  Patrice Dumas  <pertusus@free.fr>
> 
>       ...
> 
>         * tp/Texinfo/XS/parsetexi/api.c (element_to_perl_hash): do not
>         set 'contents' if empty.
> 
> I suspect at one time the contents should have been set to an empty
> array, so that the code would have worked.  It would be easy
> to add an extra check for the contents being defined, but I wonder
> how much other code there is like this that could break.

This is quite possible that there are similar places.  If you look at
that specific code, all the other cases were actually fixed, but this
one slipped.

> Patrice, would you be able to look at this?

Yes, I have something ready.

-- 
Pat