Re: Texinfo 7.0.92 pretest on NetBSD 9.0

[Patrice Dumas]

On Tue, Sep 19, 2023 at 04:22:42PM +0200, Bruno Haible wrote:
> The origin of the bug is here:
> $ grep -n CPPFLAGS= tp/Texinfo/XS/configure.ac /dev/null 
> tp/Texinfo/XS/configure.ac:100:  CPPFLAGS=$PERL_EXT_CPPFLAGS
> tp/Texinfo/XS/configure.ac:152:CPPFLAGS=$PERL_EXT_CPPFLAGS

Here is a proposal for a patch.  It still sets

  CFLAGS=$PERL_EXT_CFLAGS
  CPPFLAGS=$PERL_EXT_CPPFLAGS
  LDFLAGS=$PERL_EXT_LDFLAGS

early on, such that CPPFLAGS and other flags are added to that.
I removed the other perl flags because that were previously set
at the point in the configure.ac file because I did not understand why
they would be relevant here for the gnulib macros invokations, but I may
have missed something.

I removed the setting of CFLAGS, CPPFLAGS and LDFLAGS late in
configure.ac.

I made another unrelated change, I added $(PERL_CONF_cccdlflags) to
AM_CFLAGS in Makefile.am, as it seems to me that it would be missing
there, if I understood the documentation correctly.  My feeling is that
it worked previously without that kind of flags because it is also added
by libtool, but it seems to me to be cleaner to have it there.

I can make it a proper commit with Changelog if the approach seems ok.

-- 
Pat

no_reset_flags_use_cccdlflags.diff
Description: Text Data