Re: Build failure on master

[Patrice Dumas]

On Thu, Oct 03, 2024 at 09:03:16PM +0100, Gavin Smith wrote:
> Currently, when I run "make" there are a slew of error messages (see below).

I can't reproduce, maybe because of a different Perl?  

Maybe a (SV *) cast is needed like

              const char *direction_name = SvPVutf8_nolen ((SV *)button->sv);

Maybe you can test whether it fixes your issue?

I could laso probably use the CI to see such issue.


> 
> (master branch, commit 6a80a8dbed6e, 2024-08-07 18:02:23 +0200).
> 
> I tried re-running "configure" but it made no difference.  I have not
> investigated any further.
> 
> 
> make[5]: Entering directory '/home/g/src/texinfo/GIT/tp/Texinfo/XS'
> /bin/bash ./libtool  --tag=CC   --mode=compile x86_64-linux-gnu-gcc 
> -DHAVE_CONFIG_H -I.  -I./main -I./convert -I. -DDATADIR=\"/usr/local/share\" 
> -DVERSION=\"0\" -DXS_VERSION=\"0\" -I/usr/lib/x86_64-linux-gnu/perl/5.34/CORE 
>  -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe 
> -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g -fPIC  
> -MT main/libtexinfoxs_la-get_perl_info.lo -MD -MP -MF 
> main/.deps/libtexinfoxs_la-get_perl_info.Tpo -c -o 
> main/libtexinfoxs_la-get_perl_info.lo `test -f 'main/get_perl_info.c' || echo 
> './'`main/get_perl_info.c
> libtool: compile:  x86_64-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I./main 
> -I./convert -I. -DDATADIR=\"/usr/local/share\" -DVERSION=\"0\" 
> -DXS_VERSION=\"0\" -I/usr/lib/x86_64-linux-gnu/perl/5.34/CORE -D_REENTRANT 
> -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe 
> -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g -fPIC 
> -MT main/libtexinfoxs_la-get_perl_info.lo -MD -MP -MF 
> main/.deps/libtexinfoxs_la-get_perl_info.Tpo -c main/get_perl_info.c  -fPIC 
> -DPIC -o main/.libs/libtexinfoxs_la-get_perl_info.o
> In file included from /usr/lib/x86_64-linux-gnu/perl/5.34/CORE/perl.h:4076,
>                  from main/get_perl_info.c:25:
> main/get_perl_info.c: In function ‘html_fill_button_sv_specification_list’:
> /usr/lib/x86_64-linux-gnu/perl/5.34/CORE/sv.h:340:29: warning: dereferencing 
> ‘void *’ pointer
>   340 | #define SvFLAGS(sv)     (sv)->sv_flags
>       |                             ^~
> /usr/lib/x86_64-linux-gnu/perl/5.34/CORE/sv.h:340:29: note: in definition of 
> macro ‘SvFLAGS’
>   340 | #define SvFLAGS(sv)     (sv)->sv_flags
>       |                             ^~
> /usr/lib/x86_64-linux-gnu/perl/5.34/CORE/sv.h:1925:6: note: in expansion of 
> macro ‘SvPOK_utf8_nog’
>  1925 |     (SvPOK_utf8_nog(sv) \
>       |      ^~~~~~~~~~~~~~
> main/get_perl_info.c:864:44: note: in expansion of macro ‘SvPVutf8_nolen’
>   864 |               const char *direction_name = SvPVutf8_nolen 
> (button->sv);
>       |                                            ^~~~~~~~~~~~~~
> /usr/lib/x86_64-linux-gnu/perl/5.34/CORE/sv.h:340:29: error: request for 
> member ‘sv_flags’ in something not a structure or union
>   340 | #define SvFLAGS(sv)     (sv)->sv_flags
>       |                             ^~
> /usr/lib/x86_64-linux-gnu/perl/5.34/CORE/sv.h:340:29: note: in definition of 
> macro ‘SvFLAGS’
>   340 | #define SvFLAGS(sv)     (sv)->sv_flags
>       |                             ^~
> /usr/lib/x86_64-linux-gnu/perl/5.34/CORE/sv.h:1925:6: note: in expansion of 
> macro ‘SvPOK_utf8_nog’
>  1925 |     (SvPOK_utf8_nog(sv) \
>       |      ^~~~~~~~~~~~~~
> main/get_perl_info.c:864:44: note: in expansion of macro ‘SvPVutf8_nolen’
>   864 |               const char *direction_name = SvPVutf8_nolen 
> (button->sv);
>       |                                       
> /usr/lib/x86_64-linux-gnu/perl/5.34/CORE/sv.h:1293:28: warning: dereferencing 
> ‘void *’ pointer
>  1293 | #    define SvPVX(sv) ((sv)->sv_u.svu_pv)
>       |                            ^~
> /usr/lib/x86_64-linux-gnu/perl/5.34/CORE/sv.h:1293:28: note: in definition of 
> macro ‘SvPVX’
>  1293 | #    define SvPVX(sv) ((sv)->sv_u.svu_pv)
>       |                            ^~
> main/get_perl_info.c:864:44: note: in expansion of macro ‘SvPVutf8_nolen’
>   864 |               const char *direction_name = SvPVutf8_nolen 
> (button->sv);
>       |                                            ^~~~~~~~~~~~~~
> /usr/lib/x86_64-linux-gnu/perl/5.34/CORE/sv.h:1293:28: error: request for 
> member ‘sv_u’ in something not a structure or union
>  1293 | #    define SvPVX(sv) ((sv)->sv_u.svu_pv)
>       |                            ^~
> /usr/lib/x86_64-linux-gnu/perl/5.34/CORE/sv.h:1293:28: note: in definition of 
> macro ‘SvPVX’
>  1293 | #    define SvPVX(sv) ((sv)->sv_u.svu_pv)
>       |                            ^~
> main/get_perl_info.c:864:44: note: in expansion of macro ‘SvPVutf8_nolen’
>   864 |               const char *direction_name = SvPVutf8_nolen 
> (button->sv);
>       |                                            ^~~~~~~~~~~~~~
> make[5]: *** [Makefile:3227: main/libtexinfoxs_la-get_perl_info.lo] Error 1
> make[5]: Leaving directory '/home/g/src/texinfo/GIT/tp/Texinfo/XS'
> make[4]: *** [Makefile:3281: all-recursive] Error 1
> 
>