Re: FreeBSD failures with env for in document translations for master

[Gavin Smith]

On Sat, Sep 21, 2024 at 11:17:49PM +0200, Patrice Dumas wrote:
> Hello,
> 
> The CI for the master branch for FreeBSD shows errors related to in
> document translations in the XS/C code.  These errors seem to trigger
> some kind of memory corruption, with an errno code that is not supposed
> to be issued by setenv 'Bad address' and those errors seem to propagate
> across processes:
> 
> perl: environment corrupt; missing value for
> sh: environment corrupt; missing value for 
> 
> ...
> perl: environment corrupt; missing value for
> translate_string: setenv `ja' error for string `{name} of {class}': Bad 
> address
> 
> It is unclear to me whether the issue here is in Texinfo code (in that
> case probably in tp/Texinfo/XS/main/translations.c translate_string) or
> in FreeBSD.
> 
> I attach the full tp/t*.t log.

We have had memory errors with setenv in XS code before.

I wrote on November 16, 2023 (private mail):

> I found this entry in "man perldelta" for 5.38.0:
>
>        •   Perl is no longer manipulating the "environ" array directly. The
>            variable "PL_use_safe_putenv" has been removed and
>            "PERL_USE_SAFE_PUTENV" is always defined. This means XS modules can
>            now call "setenv" and "putenv" without causing segfaults. [perl
>            #19399 <https://github.com/Perl/perl5/issues/19399>]
>
> I don't know the perl internals enought to say whether this is exactly the
> same problem that we were facing, but it seems to be fixed, anyway.  Linked
> reports seemed similar to the problem we had.

This was in relation to many errors being logged by valgrind.

Do you know what version of Perl is in use?

Does this report relate to https://github.com/gnu-texinfo/ci-check?
Do you have a more specific link about where to get the build reports?