[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: A minor bug in java.io.File: Submit for Classpath
From: |
Brian Jones |
Subject: |
Re: A minor bug in java.io.File: Submit for Classpath |
Date: |
05 Jul 2001 23:34:36 -0400 |
User-agent: |
Gnus/5.0803 (Gnus v5.8.3) Emacs/20.7 |
"Wu, Gansha" <address@hidden> writes:
> We found a minor bug in java.io.File when we tried to run Volano
> benchmark on ORP with Classpath.
> Here's the senario:
> File file = new File(System.getProperty(propname), filename);
> While System.getProperty(propname) return null, then the constructor:
> File(String dirname, String name){
> this(dirname + separator + name);
> }
> assumes that a file with filename must exist under the directory
> named "null".
> An approperiate modification is to add a check like this:
> this(dirname == null?name:dirname + separator + name);
> The context compare result below is based on gnu classpath cvs snapshot
> of June 22.Note that revision number is different from public CVS.
>
I implemented it this way instead of the way you later submitted. My
reasoning here is that if name is null, the vm will naturally throw a
NullPointerException at this point without us having to explicitly
check and throw it ourselves.
Brian
--
Brian Jones <address@hidden>
- Re: A minor bug in java.io.File: Submit for Classpath,
Brian Jones <=