[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] config.sub: Factor out `invalid_config` function
From: |
Zack Weinberg |
Subject: |
Re: [PATCH 2/3] config.sub: Factor out `invalid_config` function |
Date: |
Thu, 21 Sep 2023 16:46:18 -0400 |
User-agent: |
Cyrus-JMAP/3.9.0-alpha0-761-gece9e40c48-fm-20230913.001-gece9e40c |
On Thu, Sep 21, 2023, at 3:52 PM, John Ericson wrote:
...
> # Functions
> ###########
>
> +# Invalid configuration; display a message and exit
> +#
> +# Param 1: configuration
> +# Param 2: message
> +invalid_config () {
> + echo "Invalid configuration '$1': $2" 1>&2
> + exit 1
> +}
Um. I don't think you can use shell functions in this file (or in
config.guess), for the same reason you can't use $(...).
zw
- [PATCH 1/3] config.sub: Start moving code into functions, John Ericson, 2023/09/21
- [PATCH 3/3] config.sub: Factor out single-field shorthands, John Ericson, 2023/09/21
- [PATCH 2/3] config.sub: Factor out `invalid_config` function, John Ericson, 2023/09/21
- Re: [PATCH 2/3] config.sub: Factor out `invalid_config` function,
Zack Weinberg <=
- Re: [PATCH 2/3] config.sub: Factor out `invalid_config` function, Jacob Bachmeyer, 2023/09/21
- Re: [PATCH 2/3] config.sub: Factor out `invalid_config` function, John Cotton Ericson, 2023/09/22
- Re: [PATCH 2/3] config.sub: Factor out `invalid_config` function, Zack Weinberg, 2023/09/25
- Re: [PATCH 2/3] config.sub: Factor out `invalid_config` function, John Cotton Ericson, 2023/09/25
- Re: [PATCH 2/3] config.sub: Factor out `invalid_config` function, Zack Weinberg, 2023/09/25
- Re: [PATCH 2/3] config.sub: Factor out `invalid_config` function, John Cotton Ericson, 2023/09/25
- Re: [PATCH 2/3] config.sub: Factor out `invalid_config` function, Zack Weinberg, 2023/09/25
- Re: [PATCH 2/3] config.sub: Factor out `invalid_config` function, Jacob Bachmeyer, 2023/09/25