Re: dejagnu.h and GCC 5's change to -std=gnu11

[Steve Ellcey]

On Wed, 2014-10-22 at 04:10 -0400, David Malcolm wrote:

> Quoting a comment in the bug report:
> > That means dejagnu.h assumes the GNU inline semantics, but
> > doesn't use __gnu_inline__ attribute.  So, either compile with
> > -fgnu89-inline, or get dejagnu.h fixed.

I think we should fix dejagnu.h by adding static to the inline
functions.  Here is a dejagnu patch that works for me.  It should be
fine for old or new GCC compilers.

David, does this patch fix the problem for you?

Steve Ellcey
address@hidden


2014-10-22  Steve Ellcey  <address@hidden>

        * dejagnu.h (pass): Make function static as well as inline.
        (xpass): Ditto.
        (fail): Ditto.
        (xfail): Ditto.
        (untested): Ditto.
        (unresolved): Ditto.
        (note): Ditto.
        (totals): Ditto.

diff --git a/dejagnu.h b/dejagnu.h
index ff84bd7..45ee070 100644
--- a/dejagnu.h
+++ b/dejagnu.h
@@ -60,7 +60,7 @@ wait (void)
 #endif
 }
 
-inline void
+static inline void
 pass (const char* fmt, ...)
 {
   va_list ap;
@@ -73,7 +73,7 @@ pass (const char* fmt, ...)
   wait ();
 }
 
-inline void
+static inline void
 xpass (const char* fmt, ...)
 {
   va_list ap;
@@ -86,7 +86,7 @@ xpass (const char* fmt, ...)
   wait ();
 }
 
-inline void
+static inline void
 fail (const char* fmt, ...)
 {
   va_list ap;
@@ -99,7 +99,7 @@ fail (const char* fmt, ...)
   wait ();
 }
 
-inline void
+static inline void
 xfail (const char* fmt, ...)
 {
   va_list ap;
@@ -112,7 +112,7 @@ xfail (const char* fmt, ...)
   wait ();
 }
 
-inline void
+static inline void
 untested (const char* fmt, ...)
 {
   va_list ap;
@@ -125,7 +125,7 @@ untested (const char* fmt, ...)
   wait ();
 }
 
-inline void
+static inline void
 unresolved (const char* fmt, ...)
 {
   va_list ap;
@@ -138,7 +138,7 @@ unresolved (const char* fmt, ...)
   wait ();
 }
 
-inline void
+static inline void
 note (const char* fmt, ...)
 {
   va_list ap;
@@ -150,7 +150,7 @@ note (const char* fmt, ...)
   wait ();
 }
 
-inline void
+static inline void
 totals (void)
 {
   printf ("\nTotals:\n");