Re: [PATCH 0/1] New option for runtest to log

dejagnu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/1] New option for runtest to log_user to stdout

From:	Ben Elliston
Subject:	Re: [PATCH 0/1] New option for runtest to log_user to stdout
Date:	Fri, 15 May 2015 10:20:38 +1000
User-agent:	Mutt/1.5.23 (2014-03-12)

On Wed, May 06, 2015 at 03:04:09PM -0700, Filipe Brandenburger wrote:

> So, I'm proposing adding a new option (--log_user is my suggestion,
> but feel free to pick something else) to allow enabling "log_user"
> expect output to stdout without the need to increase verbosity.

I don't have a problem with the patch in priciple.  I can see it would
be useful, and it's optional.  However, calling the option 'log_user'
exposes details of Expect.  I would rather not do that.  Can you
rename the option to perhaps --log_dialog?  Better to keep the
underscore for consistency with older, existing two-word options (eg,
--tool_opts).

Can you please update the patch and send it again?

Thanks, Ben

signature.asc
Description: Digital signature

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 0/1] New option for runtest to log_user to stdout, Filipe Brandenburger, 2015/05/06
- [PATCH 1/1] Introduce new --log_user option to also send expect logs to stdout, Filipe Brandenburger, 2015/05/06
  - Re: [PATCH 1/1] Introduce new --log_user option to also send expect logs to stdout, Ben Elliston, 2015/05/07
    - Re: [PATCH 1/1] Introduce new --log_user option to also send expect logs to stdout, Filipe Brandenburger, 2015/05/07
    - [PATCH v2 1/1] Introduce new --log_user option to also send expect logs to stdout, Filipe Brandenburger, 2015/05/07
    - Re: [PATCH v2 1/1] Introduce new --log_user option to also send expect logs to stdout, Filipe Brandenburger, 2015/05/11
- Re: [PATCH 0/1] New option for runtest to log_user to stdout, Ben Elliston <=
  - Re: [PATCH 0/1] New option for runtest to log_user to stdout, Filipe Brandenburger, 2015/05/15
    - [PATCH v3 1/1] Introduce new --log_dialog option to emit expect output to stdout, Filipe Brandenburger, 2015/05/15

Prev by Date: Re: [PATCH v2 1/1] Introduce new --log_user option to also send expect logs to stdout
Next by Date: Re: [PATCH 0/1] New option for runtest to log_user to stdout
Previous by thread: Re: [PATCH v2 1/1] Introduce new --log_user option to also send expect logs to stdout
Next by thread: Re: [PATCH 0/1] New option for runtest to log_user to stdout
Index(es):
- Date
- Thread