dejagnu
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/4] Handle test execution timeout consistently across protoc


From: Jacob Bachmeyer
Subject: Re: [PATCH 0/4] Handle test execution timeout consistently across protocols
Date: Tue, 12 Dec 2023 21:47:38 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.22) Gecko/20090807 MultiZilla/1.8.3.4e SeaMonkey/1.1.17 Mnenhy/0.7.6.0

Maciej W. Rozycki wrote:
The intent is to avoid having to override the respective TCL procedures locally just to correct the timeout handling shortcomings in the versions shipped with DejaGNU.

Upstreaming changes like these is very important because monkeypatching the framework is not and cannot be supported and may break in various strange ways in the future.

[...]

A change for the timeout factor will follow. As it consists of a DejaGNU part and a GCC part I chose to send it separately so as not to cross-post this whole series between the DejaGNU and GCC mailing lists.

 Any questions, comments, or concerns?  Otherwise please apply.

Patches 1, 2, and 3 applied as offered on branch mwr-patch-20231212. Patch 4 has been revised and applied on the branch because the command to be executed is free-form text while the timeout is a simple number; the revised format ("Executing on MACHINE with timeout TIMEOUT: COMMAND") is easier to reliably parse.


-- Jacob




reply via email to

[Prev in Thread] Current Thread [Next in Thread]