Re: [PATCH] better isearch support for complex input methods

[Karl Fogel]

Andreas Schwab <address@hidden> writes:
> |> And, I think C-c is the better binding.
> 
> I don't think so.  C-c has already a defined meaning as a prefix key and
> should not be overloaded by isearch.

I agree with Andreas.

The important question is, which binding is _least_ likely to be used
by people as an "exit isearch and start doing something else" key.
C-o meets this test better than C-c, because C-c is the start of many
commands, whereas C-o is the start of just one command, `open-line'.

open-line is a very unlikely command to exit isearch mode with,
because you usually don't open a new line immediately on having
reached a search match.  After all, most of the time, you're at some
random point in the match, depending on how many characters you needed
to type to reach the desired match.  Therefore, the chances are low
that it would also be an appropriate spot to open a new line.

Kenichi Handa <address@hidden> writes:
> 21.2.  But, the command name should be isearch-yank-char (or
> isearch-yank-character) because it pulls not only letters
> but also newline, tab, space, etc.

Good point, thanks.  I will change it to `isearch-yank-char'.

Does anyone have a problem with my committing this change, then?

-Karl