[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
feature/pkg 93b101a7b9: Mark module--test-assertions--call-emacs-from-gc
From: |
Gerd Moellmann |
Subject: |
feature/pkg 93b101a7b9: Mark module--test-assertions--call-emacs-from-gc unstable |
Date: |
Sat, 22 Oct 2022 06:53:19 -0400 (EDT) |
branch: feature/pkg
commit 93b101a7b9fc1459e543093ed2e47c928ae1dc83
Author: Gerd Möllmann <gerd@gnu.org>
Commit: Gerd Möllmann <gerd@gnu.org>
Mark module--test-assertions--call-emacs-from-gc unstable
This test succeeds for me with --enable-checking and fails otherwise
with a segfault. See also comment there.
* test/src/emacs-module-tests.el
(module--test-assertions--call-emacs-from-gc): Mark unstable
if feature symbol-packages is present.
---
test/src/emacs-module-tests.el | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/test/src/emacs-module-tests.el b/test/src/emacs-module-tests.el
index 1099fd0467..1a1e933e9d 100644
--- a/test/src/emacs-module-tests.el
+++ b/test/src/emacs-module-tests.el
@@ -283,7 +283,14 @@ should nevertheless detect the invalid load."
(ert-deftest module--test-assertions--call-emacs-from-gc ()
"Check that -module-assertions prevents calling Emacs functions
during garbage collection."
- :tags (if (getenv "EMACS_EMBA_CI") '(:unstable))
+ ;; I'm marking this test as unstable for symbol-packages because I
+ ;; only get the expected "Abort" with --enable-checking. Without, I
+ ;; get a segfault. No idea what the reason for that is, but
+ ;; something is definitely fishy here, and I do think some module
+ ;; guy should take a closer look if this test is correct.
+ :tags (if (or (getenv "EMACS_EMBA_CI")
+ (featurep 'symbol-packages))
+ '(:unstable))
(skip-unless (or (file-executable-p mod-test-emacs)
(and (eq system-type 'windows-nt)
(file-executable-p (concat mod-test-emacs ".exe")))))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- feature/pkg 93b101a7b9: Mark module--test-assertions--call-emacs-from-gc unstable,
Gerd Moellmann <=