emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 77f240012f1: (loaddefs-generate--compute-prefixes): Fix thinko in


From: Stefan Monnier
Subject: master 77f240012f1: (loaddefs-generate--compute-prefixes): Fix thinko in last change
Date: Tue, 6 Feb 2024 15:36:29 -0500 (EST)

branch: master
commit 77f240012f1e9a7cfee60adedebc8e6a230ce49b
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    (loaddefs-generate--compute-prefixes): Fix thinko in last change
    
    * lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate--compute-prefixes):
     Fix thinko in last change.  Also,       reduce memory allocation.
---
 lisp/emacs-lisp/loaddefs-gen.el | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
index 7cfb14ace5f..1e91e84157d 100644
--- a/lisp/emacs-lisp/loaddefs-gen.el
+++ b/lisp/emacs-lisp/loaddefs-gen.el
@@ -499,16 +499,17 @@ don't include."
 
 (defun loaddefs-generate--compute-prefixes (load-name)
   (goto-char (point-min))
-  (let ((prefs nil))
+  (let ((prefs nil)
+        (temp-obarray (obarray-make)))
     ;; Avoid (defvar <foo>) by requiring a trailing space.
     (while (re-search-forward
             "^(\\(def[^ \t\n]+\\)[ \t\n]+['(]*\\([^' ()\"\n]+\\)[\n \t]" nil t)
       (unless (member (match-string 1) autoload-ignored-definitions)
         (let* ((name (match-string-no-properties 2))
                ;; Consider `read-symbol-shorthands'.
-               (probe (let ((obarray (obarray-make)))
+               (probe (let ((obarray temp-obarray))
                         (car (read-from-string name)))))
-          (when (symbolp name)
+          (when (symbolp probe)
             (setq name (symbol-name probe))
             (when (save-excursion
                     (goto-char (match-beginning 0))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]