[nongnu] elpa/hyperdrive b6e26b7759 11/15: Change: Remove hyperdrive-reuse-buffers

[ELPA Syncer]

branch: elpa/hyperdrive
commit b6e26b7759d35d33b9bdce8c04c36a61dbb3dcd6
Author: Joseph Turner <joseph@ushin.org>
Commit: Joseph Turner <joseph@ushin.org>

    Change: Remove hyperdrive-reuse-buffers
    
    When implementing the uniquification code, it became clear that it
    wasn't feasible to attempt to handle all of the edge cases where
    multiple buffers could accidentally be created that visit the same
    entry at different versions.
    
    By removing the feature, we simplify the expected behavior and allow
    users to kill extra buffers as they see fit.
---
 CHANGELOG.org       |  2 ++
 DEV.org             | 14 --------------
 doc/hyperdrive.org  |  8 --------
 doc/hyperdrive.texi |  8 --------
 hyperdrive-lib.el   |  7 ++-----
 hyperdrive-vars.el  |  9 ---------
 6 files changed, 4 insertions(+), 44 deletions(-)

diff --git a/CHANGELOG.org b/CHANGELOG.org
index f2e5d3c9ee..cf9285419a 100644
--- a/CHANGELOG.org
+++ b/CHANGELOG.org
@@ -16,6 +16,8 @@ This project adheres to 
[[https://semver.org/spec/v2.0.0.html][Semantic Versioni
 - Improved defcustom types
 - Better error message when ~hyper-gateway~ is not installed.  Thanks to
   ~magnum~ on XMPP for reporting.
+- Removed ~hyperdrive-reuse-buffers~ user option to ensure consistent
+  behavior when uniquifying buffer names.
 
 ** Fixed
 
diff --git a/DEV.org b/DEV.org
index 124b008ddf..3d0cf942aa 100644
--- a/DEV.org
+++ b/DEV.org
@@ -218,20 +218,6 @@ What hyperdrive does:
 | Already exists        | write-buffer | Prompt to overwrite         |         
          |
 | Already exists        | save-buffer  | Overwrite without prompting |         
          |
 
-** hyperdrive-write-buffer matrix
-
-| h/reuse-buffers | current buf  | context             | expected result       
                                      | works? |
-|-----------------+--------------+---------------------+-------------------------------------------------------------+--------|
-| any-version     | latest entry |                     | Buf not renamed, only 
one buf at entry                      |        |
-| any-version     | prev entry   |                     | Buf renamed, only one 
buf at entry                          |        |
-| any-version     | other        | No buf at latest    | Buf renamed, only one 
buf at entry                          |        |
-| any-version     | other        | Other buf at latest | Other buf killed, buf 
renamed, only one buf at entry        |        |
-| same-version    | latest entry |                     | Buf not renamed, only 
one buf at latest entry               |        |
-| same-version    | prev entry   | No buf at latest    | Buf renamed, only one 
buf at _latest_ entry                   |        |
-| same-version    | prev entry   | Other buf at latest | Other buf killed, buf 
renamed, only one buf at _latest_ entry |        |
-| same-version    | other        | No buf at latest    | Buf renamed, only one 
buf at _latest_ entry                   |        |
-| same-version    | other        | Other buf at latest | Other buf killed, buf 
renamed, only one buf at _latest_ entry |        |
-
 * DONE Conference presentation
 :LOGBOOK:
 - State "DONE"       from "PROJECT"    [2023-04-04 Tue 13:33] \\
diff --git a/doc/hyperdrive.org b/doc/hyperdrive.org
index 2325e03b54..8bfb862671 100644
--- a/doc/hyperdrive.org
+++ b/doc/hyperdrive.org
@@ -1109,14 +1109,6 @@ running ~M-x customize-group RET hyperdrive RET~:
   Default maximum number of requests when filling version history.
   Defaults to ~100~.
 
-- User Option: hyperdrive-reuse-buffers ::
-
-  How to reuse buffers when showing entries.  By default
-  (~any-version~), opening a hyperdrive file or directory reuses a
-  buffer that is already visiting it, regardless of version.  To have
-  separate buffers for each version of a file/directory, use
-  ~same-version~.
-
 - User Option: hyperdrive-preferred-formats ::
 
   List of metadata types used to display hyperdrives.  Hyperdrives are
diff --git a/doc/hyperdrive.texi b/doc/hyperdrive.texi
index 8f9ff859b4..36ee5e0655 100644
--- a/doc/hyperdrive.texi
+++ b/doc/hyperdrive.texi
@@ -1475,14 +1475,6 @@ Default maximum number of requests when filling version 
history.
 Defaults to @code{100}.
 @end defopt
 
-@defopt hyperdrive-reuse-buffers
-How to reuse buffers when showing entries.  By default
-(@code{any-version}), opening a hyperdrive file or directory reuses a
-buffer that is already visiting it, regardless of version.  To have
-separate buffers for each version of a file/directory, use
-@code{same-version}.
-@end defopt
-
 @defopt hyperdrive-preferred-formats
 List of metadata types used to display hyperdrives.  Hyperdrives are
 displayed using the first available metadata type.  See @ref{Naming}
diff --git a/hyperdrive-lib.el b/hyperdrive-lib.el
index bf3cfdf23a..adf9708883 100644
--- a/hyperdrive-lib.el
+++ b/hyperdrive-lib.el
@@ -1530,11 +1530,8 @@ corresponding to URL if possible.
 
 In other words, this avoids the situation where a buffer called
 \"foo:/\" and another called \"hyper://<public key for foo>/\"
-both point to the same content.
-
-Affected by option `hyperdrive-reuse-buffers', which see."
-  (let* ((existing-buffer
-          (h//find-buffer-visiting entry (eq 'any-version h/reuse-buffers)))
+both point to the same content."
+  (let* ((existing-buffer (h//find-buffer-visiting entry))
          (buffer
           (if (not existing-buffer)
               ;; No existing buffer visiting entry: make new buffer.
diff --git a/hyperdrive-vars.el b/hyperdrive-vars.el
index 81b3279c70..f20e5bfae5 100644
--- a/hyperdrive-vars.el
+++ b/hyperdrive-vars.el
@@ -136,15 +136,6 @@ through a shell)."
   "Render HTML hyperdrive files with EWW."
   :type 'boolean)
 
-(defcustom h/reuse-buffers 'any-version
-  "How to reuse buffers when showing entries.
-When \\+`any-version', try to reuse an existing buffer showing the
-same entry at any version.  When \\+`same-version', try to reuse
-an existing buffer at the same version, or make a new buffer."
-  :type '(choice
-          (const :tag "Use an existing buffer at any version" any-version)
-          (const :tag "Use an existing buffer at the same version" 
same-version)))
-
 ;;;;;; Entry formatting
 
 (defgroup hyperdrive-entry-format nil