[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: Fix help test to reflect updated help output
From: |
Glenn Washburn |
Subject: |
Re: [PATCH] tests: Fix help test to reflect updated help output |
Date: |
Wed, 11 Jan 2023 17:10:55 -0600 |
On Wed, 11 Jan 2023 19:48:06 +0100
Daniel Kiper <dkiper@net-space.pl> wrote:
> On Tue, Jan 10, 2023 at 03:02:15PM -0600, Glenn Washburn wrote:
> > Commit f5759a878 (normal/help: Add paging instructions to normal
> > and help prompts) changed the output of the help command, which
> > broke the help test. This change allows the test to pass.
> >
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
>
> ... but...
>
> > ---
> > tests/help_test.in | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/help_test.in b/tests/help_test.in
> > index b08cf20138..630e9860ae 100644
> > --- a/tests/help_test.in
> > +++ b/tests/help_test.in
> > @@ -8,6 +8,9 @@ Show a help message.
> >
> > -h, --help Display this help and exit.
> > -u, --usage Display the usage of this command and exit.
> > +
> > +
> > +To enable less(1)-like paging, \"set pager=1\".
> > Hello World"
> > outpu="$(echo 'help help; hello' | @builddir@/grub-shell)"
>
> We could do s/outpu/output/ on the occasion. I can do it before the
> push...
Sure thing, go ahead.
Glenn