grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 0/4] LUKS1/2 testing in fs-tester and LUKS2 support in grub-probe


From: Glenn Washburn
Subject: [PATCH 0/4] LUKS1/2 testing in fs-tester and LUKS2 support in grub-probe
Date: Thu, 12 Jan 2023 17:05:06 -0600

This series adds the testing of LUKS 1 and 2 encrypted container to the
user-space fs tester. While this does replicate some of the testing done
by grub_cmd_cryptomount, and is less flexible, it is run natively (that is
without need for virtualization). It also tests the added LUKS2 support in
grub-probe, unlike grub_cmd_cryptomount which does not test any user-space
grub components.

All of these patches have previously been sent to the list. Only patch 4 has
been slightly modified to fix some issues. Since utility of any one is greatly
enhanced, and in the case of patch 4 required, by the others, I think it makes
sense to evaluate them together.

Fabian has noted a memory leak with error handling when using LUKS2 with a
null_cipher[1]. Since this isn't something that I expect to happen in the wild
(why would you use an unencrypted LUKS container?) and even if it does occur
grub-probe is exiting, so the leak would be very short lived, I don't think
this is something that we need to worry about. It wouldn't be that hard to fix
though, just annoying and add a little more complexity to the source.

The corresponding patches can be found in the order of this series here:
 1: [PATCH v3] disk/cryptodisk: When cheatmounting, use the sector info of the 
cheat device
    https://lists.gnu.org/archive/html/grub-devel/2022-06/msg00106.html
 2: [PATCH v6 1/2] devmapper/getroot: Have devmapper recognize LUKS2
    https://lists.gnu.org/archive/html/grub-devel/2022-07/msg00036.html
 3: [PATCH v6 2/2] devmapper/getroot: Set up cheated LUKS2 cryptodisk mount 
from DM parameters
    https://lists.gnu.org/archive/html/grub-devel/2022-07/msg00038.html
 4: [PATCH v4] grub-fs-tester: Add luks1 and luks2 support
    https://lists.gnu.org/archive/html/grub-devel/2022-06/msg00127.html

Glenn

[1] https://lists.gnu.org/archive/html/grub-devel/2022-11/msg00032.html

Fabian Vogt (1):
  disk/cryptodisk: When cheatmounting, use the sector info of the cheat
    device

Josselin Poiret (2):
  devmapper/getroot: Have devmapper recognize LUKS2
  devmapper/getroot: Set up cheated LUKS2 cryptodisk mount from DM
    parameters

Pierre-Louis Bonicoli (1):
  grub-fs-tester: Add luks1 and luks2 support

 .gitignore                          |   2 +
 Makefile.util.def                   |  12 +++
 grub-core/disk/cryptodisk.c         |  20 ++++-
 grub-core/osdep/devmapper/getroot.c | 118 ++++++++++++++++++++++++++--
 tests/luks1_test.in                 |  23 ++++++
 tests/luks2_test.in                 |  23 ++++++
 tests/util/grub-fs-tester.in        |  57 +++++++++++++-
 7 files changed, 246 insertions(+), 9 deletions(-)
 create mode 100644 tests/luks1_test.in
 create mode 100644 tests/luks2_test.in

-- 
2.34.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]