Re: [v7 PATCH 0/3] Unify ARM64 & RISC-V Linux Loader

[Daniel Kiper]

On Fri, Jan 20, 2023 at 05:17:11PM -0800, Atish Patra wrote:
> This series unifies the linux loader for ARM64 & RISC-V. The linux loader
> for ARM64 is pretty much arch independent. Thus, this series just moves
> it to the common directory and update the make files.
>
> This series also removes the arch specific kernel image haders for
> ARM64 & RISC-V as suggested on v6[1]. I am not quite sure
> if there are any issues in removing ARM headers as well. It seems okay
> to me after a quick glance. If that's the case, it can be done in a
> separate path.
>
> This series has been tested with OpenSuse image in Qemu for RISC-V.
> For ARM64, it has been compile tested only.
> It would be good to get more testing on ARM64 and real RISC-V boards as well.
>
> [1] https://lists.gnu.org/archive/html/grub-devel/2022-11/msg00042.html
>
> Sorry for the delay in sending the series. Hopefully, it has not delayed the
> grub release plan.
>
> Changes from v6->v7:
> 1. Rebased on top of the latest upstream.
> 2. Addressed all the comments on v6.
> 3. Removed arch specific image header files for ARM64 & RISC-V.
>
> Changes from v5->v6:
> 1. Rebased on top of Ard's latest LoadFile2 series.
>
> Changes from v4->v5:
> 1. Removed redundant macros from header file and updated the rv32
>    kernel header structure.
>
> Changes from v3->V4:
> 1. Added all the comments on v3.
> 2. Dropped LoadFile2 patches as Ard's series[1] updated those patches
>
> Atish Patra (3):
> loader: Move arm64 linux loader to common code
> efi: Remove arch specific image headers for RISC-V & ARM64
> RISC-V: Use common linux loader
>
> grub-core/Makefile.core.def             |  8 ++--
> grub-core/commands/file.c               |  8 ++--
> grub-core/loader/arm64/xen_boot.c       |  3 +-
> grub-core/loader/{arm64 => efi}/linux.c |  1 -
> grub-core/loader/riscv/linux.c          | 59 -------------------------
> include/grub/arm64/linux.h              | 48 --------------------
> include/grub/efi/efi.h                  | 11 ++++-
> include/grub/riscv32/linux.h            | 41 -----------------
> include/grub/riscv64/linux.h            | 43 ------------------
> 9 files changed, 19 insertions(+), 203 deletions(-)
> rename grub-core/loader/{arm64 => efi}/linux.c (99%)
> delete mode 100644 grub-core/loader/riscv/linux.c
> delete mode 100644 include/grub/arm64/linux.h
> delete mode 100644 include/grub/riscv32/linux.h
> delete mode 100644 include/grub/riscv64/linux.h

For all the patches Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>...

Thank you for fixing this!

Daniel