Re: [PATCH v2 0/1] tpm: Enable boot despite unknown firmware failure

[Daniel Kiper]

On Fri, Jun 16, 2023 at 12:39:46AM +0200, Michał Grzelak wrote:
> Hi all,
>
> This patch fixes small problem with my computer being unbootable under
> certain circumstances. It also addresses concerns pointed out by Daniel
> with previous version. If there are any, I would appreciate further
> comments.
>
> Best regards,
> Michał
>
> ---
> Changelog:
> v1->v2:
> - change grub_tpm_is_fail_fatal() back to tpm_is_fail_fatal()

Nah, we should not do this because the function is global. However,
you did it due to my (wrong) suggestion. Sorry about that. I will
fix it before push.

Otherwise Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>...

Daniel

> - make is_tpm_fail_fatal() static
> - move is_tpm_fail_fatal() body to include/grub/tpm.h
> - update docs excerpt about tpm_fail_fatal
>
> Michał Grzelak (1):
>   tpm: Enable boot despite unknown firmware failure
>
>  docs/grub.texi               | 5 +++++
>  grub-core/commands/efi/tpm.c | 3 ++-
>  grub-core/commands/tpm.c     | 7 -------
>  include/grub/tpm.h           | 9 +++++++++
>  4 files changed, 16 insertions(+), 8 deletions(-)