[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] util/grub.d/25_bli.in: fix shebang on unmerged-usr
From: |
Oliver Steffen |
Subject: |
Re: [PATCH] util/grub.d/25_bli.in: fix shebang on unmerged-usr |
Date: |
Fri, 14 Jul 2023 14:04:13 -0700 |
User-agent: |
alot/0.8.1 |
Quoting Daniel Kiper (2023-07-13 20:16:40)
> On Tue, Jul 11, 2023 at 11:44:52AM -0500, Glenn Washburn wrote:
> > On Mon, 10 Jul 2023 23:55:43 -0500
> > Oskari Pirhonen <xxc3ncoredxx@gmail.com> wrote:
> >
> > > On an unmerged-usr system, grub-mkconfig errors out with the following
> > > error due to /usr/bin/sh not existing:
> > >
> > > /usr/sbin/grub-mkconfig: /etc/grub.d/25_bli: /usr/bin/sh: bad
> > > interpreter: No such file or directory
> > >
> > > Use a /bin/sh shebang to fix the error as well as match the other
> > > existing files.
> > >
> > > Signed-off-by: Oskari Pirhonen <xxc3ncoredxx@gmail.com>
> > > ---
> > > util/grub.d/25_bli.in | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/util/grub.d/25_bli.in b/util/grub.d/25_bli.in
> > > index 6e4538716..26e27a019 100644
> > > --- a/util/grub.d/25_bli.in
> > > +++ b/util/grub.d/25_bli.in
> > > @@ -1,4 +1,4 @@
> > > -#!/usr/bin/sh
> > > +#! /bin/sh
> > > set -e
> > >
> > > # grub-mkconfig helper script.
> >
> > Reviewed-by: Glenn Washburn <development@efficientek.com>
>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
>
Yeah, /bin/sh sounds much better. Thanks for fixing this.
Reviewed-by: Oliver Steffen <osteffen@redhat.com>