Re: [PATCH v2 1/2] tests: Test aborts due to missing requirements should be marked as error instead of skipped

[Julian Andres Klode]

On Thu, Oct 14, 2021 at 03:58:07PM -0500, Glenn Washburn wrote:
> Many tests abort due to not being root or missing tools, for instance mkfs
> commands for file system tests. The tests are exited with code 77, which
> means they were skipped. A skipped test is a test that should not be run,
> eg. a test specific to ARM64 should not be run on an x86 build. These aborts
> are actually a hard error, code 99. That means that the test could not be
> completed, but not because what was supposed to be tested failed, eg. in
> these cases where a missing tool prevents the running of a test.

This change is inappropriate. We can't just fail the build in distro
packaging just because our builders don't run as root.

Similarly dependencies - it's our choice which dependencies we install,
if we don't care about stuff, it should just skip it.

Every distro will have to revert this change presumably so they can
build grub.

-- 
debian developer - deb.li/jak | jak-linux.org - free software dev
ubuntu core developer                              i speak de, en