grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v9 02/11] Unify GUID types


From: Pedro Miguel Justo
Subject: Re: [PATCH v9 02/11] Unify GUID types
Date: Mon, 14 Aug 2023 23:04:20 +0000


Quoting Vladimir 'phcoder' Serbinenko (2023-08-14 13:56:31)
I uploaded the entire branch (patches) to my GitHub copy:
[1]https://github.com/phcoder/GRUB/tree/rb1


Vladimir, I can confirm that, with the code presently in this branch, my Itanium system boots fine. The regression is resolved.

This statement is valid for Itanium aline. I have not tried any other architecture.


On Aug 14, 2023, at 07:36, John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote:

Hi Pedro!

This is a known generic problem with GRUB. You must install gawk instead of mawk.

Thank you Adrian, that worked.

On Aug 14, 2023, at 21:38, Frank Scheiner <frank.scheiner@web.de> wrote:

Ard thinks that a 64 bit alignment for EFI GUIDs is a mistake - see [1]
and [2]. Hence Linux uses `__aligned(__alignof__(u32))` for "efi_guid_t"
since 2019.

[1]:
https://github.com/torvalds/linux/blob/master/include/linux/efi.h#L60-L78

[2]:
https://github.com/torvalds/linux/commit/494c704f9af0a0cddf593b381ea44320888733e6

I know I mentioned [1] earlier, but it sounds like it might have slipped
through and it might be a good idea to have both GRUB and Linux in sync
in this regard.


So what is GRUB's current allocation granule, if it is not the same as Linux?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]