Re: [PATCH v1] readd build dependency for startup_raw.S

[Glenn Washburn]

On Thu, 17 Aug 2023 11:00:44 +0200
Olaf Hering <olaf@aepfle.de> wrote:

> Wed, 16 Aug 2023 14:33:43 -0500 Glenn Washburn <development@efficientek.com>:
> 
> > There's an extra 'd' in read in the subject line.
> 
> Perhaps there is a better phrase to describe the act of adding something back?

Ah, it needs a dash, "re-add". I misinterpreted your intent.

> > I don't see this error when building any of the targets that I test.
> 
> It is the result of my attempt to build just the required binaries, without 
> docs.
> I came up with this:
>   git clean -dffx
>   bash bootstrap
>   mkdir .b
>   cd .b
>   ../configure [options]
>   make check
>   make -C grub-core install-platformDATA install-platformPROGRAMS

And this avoids the compile error for startup_raw.S?

> 
> But thinking further about it, and as others have noted, the real fix would
> be to wade through all targets and express their dependencies properly.

What version of automake are you using? I'm on 1.16.3-2 from Debian 11.
rs_decoder.h is ending up in BUILT_SOURCES, so it should get built
before anything is compiled. Can you check BUILT_SOURCES? For me
rs_decoder.h is included via a few levels of variable expansion, so it
won't be literally in the definition of BUILT_SOURCES. I'm wondering if
maybe you're using an older version of automake with a bug.

Glenn