grub-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: regression in cryptomount -u

From: Vladimir 'phcoder' Serbinenko
Subject: Re: regression in cryptomount -u
Date: Thu, 17 Aug 2023 23:41:27 +0200

     {
-      ret = (cargs->search_uuid != NULL && grub_strcasecmp (cargs->search_uuid, dev->uuid) == 0);
+      ret = cargs->search_uuid && !grub_uuidcasecmp(cargs->search_uuid, dev->uuid, sizeof(dev->uuid));

Please keep comparison with == 0 explicit. Also comparison with NULL improved readability 
reply via email to
[Prev in Thread] Current Thread [Next in Thread]