[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] grub-core/Makefile.am: Make path to extra_deps.lst relative
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH] grub-core/Makefile.am: Make path to extra_deps.lst relative to $(top_srcdir)/grub-core |
|
Date: |
Mon, 11 Dec 2023 17:20:03 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Mon, Dec 11, 2023 at 12:23:05AM -0800, Oliver Steffen wrote:
> Quoting Mate Kukri (2023-12-08 18:20:12)
> > 154dcb1aea9f8fc42b2bce98bebed004d7783a7d broke out of tree builds by
> > introducing the extra_deps.lst file into the source tree but referencing
> > it just by name in grub-core/Makefile.am.
> >
> > Signed-off-by: Mate Kukri <mate.kukri@canonical.com>
> > ---
> > grub-core/Makefile.am | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/grub-core/Makefile.am b/grub-core/Makefile.am
> > index a48ce37b4..f18550c1c 100644
> > --- a/grub-core/Makefile.am
> > +++ b/grub-core/Makefile.am
> > @@ -454,8 +454,8 @@ crypto.lst:
> > $(srcdir)/lib/libgcrypt-grub/cipher/crypto.lst
> > platform_DATA += crypto.lst
> > CLEANFILES += crypto.lst
> >
> > -syminfo.lst: gensyminfo.sh kernel_syms.lst extra_deps.lst $(MODULE_FILES)
> > - cat kernel_syms.lst extra_deps.lst > $@.new
> > +syminfo.lst: gensyminfo.sh kernel_syms.lst
> > $(top_srcdir)/grub-core/extra_deps.lst $(MODULE_FILES)
> > + cat kernel_syms.lst $(top_srcdir)/grub-core/extra_deps.lst > $@.new
> > for m in $(MODULE_FILES); do \
> > sh $< $$m >> $@.new || exit 1; \
> > done
> > --
> > 2.39.2
>
> Looks good to me.
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel