Re: [PATCH 1/2] fs/erofs: Add support for EROFS

[Daniel Kiper]

Hi Gao,

On Mon, Dec 25, 2023 at 03:26:28PM +0800, Gao Xiang wrote:
> Hi Daniel,

[...]

> It seems that GRUB 2.12 has been always released.  Is it possible to
> consider this to the upstream?

Sure thing. Though there is a holiday season here. So, expect reviews in
a few weeks.

[...]

> > > > > I have not looked into ZFS's usage of its internal library, nor how
> > > > > hard it would be to make it a separate module. But I prefer the
> > > > > separate module approach. Perhaps Daniel can speak to his preferred> 
> > > > > method.
> > >
> > > I agree with Glenn, please put/move lz4 compression code to separate 
> > > module.
> >
> > Thanks for the confirmation on this stuff!
>
> For EROFS support for compressed files, it still needs some work/review
> (mainly seperate modules) to do anyway.  IMHO, we could address them
> step-by-step.

Yeah, I think it is good idea.

Daniel