Re: [PATCH] tests: switch password quality check off for luks2 test

[Glenn Washburn]

On Fri, 29 Dec 2023 17:08:20 +0800
Gary Lin <glin@suse.com> wrote:

> When adding/changing the password for the luks2 partition, cryptsetup
> may reject the command due to the weak password. Since this is only for
> testing, add '--force-password' to switch password quality check off to
> avoid the unexpected failure.

This was caught in the fs tests but not added here. Thanks.

Reviewed-by: Glenn Washburn <development@efficientek.com>

Glenn

> Signed-off-by: Gary Lin <glin@suse.com>
> ---
>  tests/grub_cmd_cryptomount.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/grub_cmd_cryptomount.in b/tests/grub_cmd_cryptomount.in
> index 4578ab709..f4d8f3547 100644
> --- a/tests/grub_cmd_cryptomount.in
> +++ b/tests/grub_cmd_cryptomount.in
> @@ -173,7 +173,7 @@ eval testcase_fail "'LUKS2 test with argon2 pbkdf:'" \
>  # Add good password to second slot and change first slot to unchecked 
> password
>  csscript=`mktemp "${TMPDIR:-/tmp}/tmp.XXXXXXXXXX"` || exit 99
>  cat >$csscript <<'EOF'
> -    CSOPTS="--pbkdf-force-iterations 1000 --pbkdf=pbkdf2"
> +    CSOPTS="--pbkdf-force-iterations 1000 --pbkdf=pbkdf2 --force-password"
>      cryptsetup $CSOPTS --key-file $lukskeyfile luksAddKey $luksdiskfile 
> $lukskeyfile
>      echo "newpass" | cryptsetup $CSOPTS --key-file $lukskeyfile --key-slot 0 
> luksChangeKey $luksdiskfile
>  EOF