grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 3/3] loader/i386/multiboot_mbi.c: Clean up redundant code


From: Alec Brown
Subject: [PATCH 3/3] loader/i386/multiboot_mbi.c: Clean up redundant code
Date: Sat, 20 Jan 2024 02:52:51 +0000

In grub-core/loader/i386/multiboot_mbi.c, coverity spotted redundant code where
the variable err was being set to GRUB_ERR_NONE and then being overwritten
later without being used. Since this is unnecessary, we can remove the code
that sets err to GRUB_ERR_NONE.

Fixes: CID 428877

Signed-off-by: Alec Brown <alec.r.brown@oracle.com>
---
 grub-core/loader/i386/multiboot_mbi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grub-core/loader/i386/multiboot_mbi.c 
b/grub-core/loader/i386/multiboot_mbi.c
index 11a6e224f..fae5d6fb8 100644
--- a/grub-core/loader/i386/multiboot_mbi.c
+++ b/grub-core/loader/i386/multiboot_mbi.c
@@ -86,7 +86,7 @@ load_kernel (grub_file_t file, const char *filename,
        return GRUB_ERR_NONE;
       }
       if (err == GRUB_ERR_UNKNOWN_OS && (header->flags & 
MULTIBOOT_AOUT_KLUDGE))
-       grub_errno = err = GRUB_ERR_NONE;
+       grub_errno = GRUB_ERR_NONE;
     }
   if (header->flags & MULTIBOOT_AOUT_KLUDGE)
     {
-- 
2.27.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]