Re: [PATCH v9 00/22] Automatic Disk Unlock with TPM2

[Daniel Kiper]

Hey,

Adding Patrick...

On Mon, Feb 05, 2024 at 03:39:33PM +0800, Gary Lin wrote:
> GIT repo for v9: https://github.com/lcp/grub2/tree/tpm2-unlock-v9
>
> This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by
> Hernan Gatta to introduce the key protector framework and TPM2 stack
> to GRUB2, and this could be a useful feature for the systems to
> implement full disk encryption.

Sadly this patch set have many issues...

The git complains in the following way...

  Applying: asn1_test: test module for libtasn1
  .git/rebase-apply/patch:1374: new blank line at EOF.
  warning: 1 line adds whitespace errors.
  Applying: libtasn1: Add the documentation
  .git/rebase-apply/patch:90: trailing whitespace.
  .git/rebase-apply/patch:92: trailing whitespace.
  .git/rebase-apply/patch:99: trailing whitespace.
  .git/rebase-apply/patch:102: trailing whitespace.
  .git/rebase-apply/patch:108: trailing whitespace.
  warning: squelched 80 whitespace errors
  warning: 85 lines add whitespace errors.

The developers manual does not build due to following errors...

  grub-dev.texi:616: misplaced {
  grub-dev.texi:616: misplaced }
  grub-dev.texi:617: misplaced {
  grub-dev.texi:617: misplaced }
  grub-dev.texi:580: warning: node `libtasn1' is next for `minilzo' in 
sectioning but not in menu
  grub-dev.texi:599: warning: unreferenced node `libtasn1'
  grub-dev.texi:599: warning: node `minilzo' is prev for `libtasn1' in 
sectioning but not in menu
  grub-dev.texi:599: warning: node `Updating External Code' is up for 
`libtasn1' in sectioning but not in menu
  grub-dev.texi:499: node `Updating External Code' lacks menu item for 
`libtasn1' despite being its Up target

And I have attached the Coverity report. All issues reported there have
to be fixed. If you cannot fix an issue you have to explain why you
cannot do that and what is potential impact on the code stability,
security, etc.

Please do not forget to check code which you add adhere to GRUB coding
style [1]. Good example is in grub-core/kern/efi/sb.c too. Of course
this requirement does not apply to the libs which you import.

Additionally, please CC patrick.colp@oracle.com next time. He is
interested in this patch set development.

Daniel

[1] https://www.gnu.org/software/grub/manual/grub-dev/grub-dev.html#Coding-style

coverity.txt
Description: Text document