grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] build: Include grub-core/extra_deps.lst in dist


From: Oliver Steffen
Subject: Re: [PATCH] build: Include grub-core/extra_deps.lst in dist
Date: Thu, 22 Feb 2024 05:35:48 -0800
User-agent: alot/0.8.1

Quoting Daniel Kiper (2023-12-22 15:18:44)
> On Thu, Dec 21, 2023 at 01:17:35AM -0600, Oskari Pirhonen wrote:
> > Fixes build failure due to the extra_deps.lst file not existing in the
> > tarball. Found while trying to package GRUB 2.12 for Gentoo.
> >
> > make[3]: *** No rule to make target 
> > '/var/tmp/portage/sys-boot/grub-2.12/work/grub-2.12/grub-core/extra_deps.lst',
> >  needed by 'syminfo.lst'.  Stop.
> >
> > Fixes: 89fbe0cac (grub-core/Makefile.am: Make path to extra_deps.lst 
> > relative to $(top_srcdir)/grub-core)
> > Fixes: 154dcb1ae (build: Allow explicit module dependencies)
> >
> > Signed-off-by: Oskari Pirhonen <xxc3ncoredxx@gmail.com>
>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
>
> Daniel
>

I had assumed that this went in already.

I think this is OK if we want the simple solution.
For the more elaborate machinery see my patch I just sent.

Anyway,

Acked-by: Oliver Steffen <osteffen@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]