Re: [PATCH v9 00/22] Automatic Disk Unlock with TPM2

[Daniel Kiper]

On Wed, Feb 21, 2024 at 04:10:14PM +0800, Gary Lin via Grub-devel wrote:
> On Thu, Feb 08, 2024 at 08:58:43PM +0100, Daniel Kiper wrote:
> > Hey,
> >
> > Adding Patrick...
> >
> > On Mon, Feb 05, 2024 at 03:39:33PM +0800, Gary Lin wrote:
> > > GIT repo for v9: https://github.com/lcp/grub2/tree/tpm2-unlock-v9
> > >
> > > This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by
> > > Hernan Gatta to introduce the key protector framework and TPM2 stack
> > > to GRUB2, and this could be a useful feature for the systems to
> > > implement full disk encryption.
> >
> > Sadly this patch set have many issues...
> >
> > The git complains in the following way...
> >
> >   Applying: asn1_test: test module for libtasn1
> >   .git/rebase-apply/patch:1374: new blank line at EOF.
> >   warning: 1 line adds whitespace errors.
> Will be fixed in v10.
>
> >   Applying: libtasn1: Add the documentation
> >   .git/rebase-apply/patch:90: trailing whitespace.
> >   .git/rebase-apply/patch:92: trailing whitespace.
> >   .git/rebase-apply/patch:99: trailing whitespace.
> >   .git/rebase-apply/patch:102: trailing whitespace.
> >   .git/rebase-apply/patch:108: trailing whitespace.
> >   warning: squelched 80 whitespace errors
> >   warning: 85 lines add whitespace errors.
> >
> Those whitespaces naturally exist in the two 'patch' files added in this
> commit, so it's hard to avoid the warning.

OK, please ignore my comment then...

Daniel