grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add commands for reading and writing raw bytes to CMOS


From: Glenn Washburn
Subject: Re: [PATCH] Add commands for reading and writing raw bytes to CMOS
Date: Wed, 3 Apr 2024 16:59:57 -0500

On Fri, 15 Mar 2024 22:45:53 +0300
"Vladimir 'phcoder' Serbinenko" <phcoder@gmail.com> wrote:

> With some coreboot configs setting a byte to a magic value
> changes behaviour on next boot. Setting bit-by-bit is
> possible but not convenient. Add cmosread and cmoswrite for
> convenience.
> 
> Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
> 

Small nit, I think its customary to use '-s' in commands for setting
variables. '-v' would intuitively be for verbosity. Also, it would be
nice if you permanently configure your system to send patches as inline
and not as attachments. Are you not using git-send?

Glenn



reply via email to

[Prev in Thread] Current Thread [Next in Thread]